fix(deploy): fix deploy w/o aws region specified #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous patch didn't get the bug, it is on an empty list, not an empty name. This checks both.
|
The following commits need their title changed: f4fc058: @lwander fix(deploy): fix deploy w/o aws region specified The previous patch didn't get the bug, it is on an empty list, not an empty name. This checks both. Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
ablundgren
changed the title
ghost
approved these changes
Oct 18, 2018
ghost
merged commit 
|
Thanks! |
This was referenced Oct 25, 2018
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous patch didn't get the bug, it is on an empty list, not an empty name. This checks both.
spinnaker/spinnaker#3280