Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backup): allow long filenames #1085

Merged
merged 1 commit into from
Oct 24, 2018
Merged

feat(backup): allow long filenames #1085

merged 1 commit into from
Oct 24, 2018

Conversation

kevinawoo
Copy link
Member

I was getting errors like

java.lang.RuntimeException: file name '....' is too long ( > 100 bytes)

Looking at the docs, http://commons.apache.org/proper/commons-compress/tar.html#Long_File_Names

LONGFILE_POSIX: use a PAX extended header as defined by POSIX 1003.1. Most modern tar implementations are able to extract such archives. since Commons Compress 1.4

hal backup restore works fine with long filenames without a problem.

lwander
lwander approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@lwander lwander merged commit c83e889 into spinnaker:master Oct 24, 2018
@kevinawoo kevinawoo deleted the feature/tar-long-file-names branch October 24, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwander lwander lwander approved these changes

Assignees
No one assigned
Labels
target-release/1.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinawoo @lwander @spinnakerbot