Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy/kubernetes): custom sidecars configmaps #1096

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

lwander
Copy link
Member

@lwander lwander commented Oct 30, 2018

...
deploymentEnvironment:
  sidecars:  
    spin-clouddriver:
    - name: creds
      env:
        one: two
      command:
      - custom
      args:
      - build
      - credentials
      mountPath: /home/spinnaker/.aws
      dockerImage: busybox
      configMapVolumeMounts:
      - configMapName: demo
        mountPath: /path/to/config

#1080

@lwander lwander requested a review from jtk54 October 30, 2018 19:10
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lwander lwander merged commit a933118 into spinnaker:master Oct 30, 2018
@lwander lwander deleted the custom-configmaps branch October 30, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants