Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(artifacts): Add support for helm/chart artifacts #1097

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

eromanova
Copy link
Contributor

@eromanova
Copy link
Contributor Author

@spinnaker/reviewers review, please

@jfillo
Copy link
Contributor

jfillo commented Nov 19, 2018

I'm not an official reviewer, but I think there should be some changes to allow the Halyard CLI to manage this configuration.

See

Also - features like this should also include a PR to update the official documentation. https://www.spinnaker.io/setup/artifacts/

Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As @jfillo noted, you'll want to add the HelmArtifactProviderCommand so this can be configured via the command line.

The documentation will actually auto-generate once you've added that if you run make from the halyard-cli subdirectory; you can just submit those auto-generated docs along with the rest of the changes.

}

@Override
public void accept(ConfigProblemSetBuilder psBuilder, Validator v) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we could push this up to the base class in ArtifactProvider. (I realize all the existing accounts have overridden it, but seems like a good opportunity to avoid duplicating the code again.)

@eromanova
Copy link
Contributor Author

Thank you for review, guys @ezimanyi @jfillo. I added halyard cli support for helm artifact acconts and provided small changes according to @ezimanyi comment. Docs are also updated.

@ezimanyi
Copy link
Contributor

@eromanova : Looks great, thanks for the changes.

@ezimanyi ezimanyi merged commit 0af87ad into spinnaker:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants