Add aws cli to container build #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed: 77cb867: Add aws cli to container build Per discussion in spinnaker/spinnaker#2394, adding awscli to container Signed-off-by: Joe Hohertz joe@viafoura.com Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
Per discussion in spinnaker/spinnaker#2394, adding awscli to container such that the features added in spinnaker/spinnaker#2941 to enable an external passwordCommand for a docker registry can be utilized by AWS users wishing to add their ECR-based docker registries. Signed-off-by: Joe Hohertz <joe@viafoura.com>
jhohertz
force-pushed
the
add-awscli-to-container
branch
from
77cb867
to
fc0bdc4
Compare
lwander
approved these changes
Nov 13, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in spinnaker/spinnaker#2394, adding awscli to container
such that the features added in spinnaker/spinnaker#2941 to enable
an external passwordCommand for a docker registry can be utilized by
AWS users wishing to add their ECR-based docker registries.
Signed-off-by: Joe Hohertz joe@viafoura.com