fix(kubernetes/v2): Adds imagePullSecrets to podSpec.yml for V2 Kubernetes deployments #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed: 3b7abe7: Assign imagePullSecrets to podSpec.yml and update podSpec jinja template. Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
… podSpec jinja template.
davepersing
force-pushed
the
fix-k8s-v2-imagepullsecrets
branch
from
3b7abe7
to
e4d7da0
Compare
kevinawoo
pushed a commit
to armory-io/halyard
that referenced
this pull request
Nov 21, 2018
… podSpec jinja template. (spinnaker#1104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this recently when trying to deploy to an EKS cluster using manifest-based deployments.