refactor(core): Push validation logic to base class #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All subclasses of Node currently implement accept identically; push the implementation to the base class to remove a lot of duplicated code.
In most cases, we want the children of a given node to be any declared fields that are also nodes; many nodes currently implement getChildren identically via a call to makeReflectiveIterator. Even in cases where getChildren is defined as an empty iterator or as an explicit iteration, it is usually just an explicit expression of what makeReflectiveIterator would produce. This change implements getChildren in the base class as a call to makeReflectiveIterator. It does not remove overrides that explicitly define their own iterator (even if that iterator is identical to that generated by makeReflectiveIterator).
kevinawoo
added a commit
to armory-io/halyard
that referenced
this pull request
Nov 30, 2018
* master: feat(deploy/kubernetes): custom volume mnt per svc (spinnaker#1110) refactor(core): Push validation logic to base class (spinnaker#1108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to reduce the amount of code needed to add a new halyard config parameter; details on each commit message.