Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider/dcos): Fix deserialization error for DCOSAccount.Cluster… #1139

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

willgorman
Copy link
Contributor

…Credential

Attempting to add a DC/OS account fails with the error

Caused by: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of `com.netflix.spinnaker.halyard.config.model.v1.providers.dcos.DCOSAccount$ClusterCredential` (no Creators, like default construct, exist): cannot deserialize from Object value (no delegate- or property-based Creator)
 at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: com.netflix.spinnaker.halyard.config.model.v1.providers.dcos.DCOSAccount["clusters"]->java.util.ArrayList[0])

This appears to have been introduced with b5a09b7. I think that it may be due to changing the version of lombok and projectlombok/lombok#1563. The change in this PR is the one suggested in that issue as a way to resolve the problem and it seems to work here.

Disclaimer:

I know very little about lombok and don't know if this could break anything else. I only validated adding a DC/OS account and ran the tests for the project. I'm also not clear why this causes an issue only for DCOSAccount.ClusterCredential when it appears similar to many of the other @Data lombok classes in the project that aren't affected by this issue.

@lwander
Copy link
Member

lwander commented Jan 8, 2019

This change LGTM, let's see how it does in our nightly builds/deploys

@lwander lwander merged commit 19b4815 into spinnaker:master Jan 8, 2019
dbyron0 pushed a commit to dbyron0/halyard that referenced this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants