feat(deploy/kubernetes) - add ability for sidecars to be applied by canonical name #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perek
changed the title
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
lwander
approved these changes
Jan 8, 2019
...naker/halyard/deploy/spinnaker/v1/service/distributed/kubernetes/v2/KubernetesV2Service.java
Outdated
Show resolved
Hide resolved
...naker/halyard/deploy/spinnaker/v1/service/distributed/kubernetes/v2/KubernetesV2Service.java
Outdated
Show resolved
Hide resolved
...naker/halyard/deploy/spinnaker/v1/service/distributed/kubernetes/v2/KubernetesV2Service.java
Outdated
Show resolved
Hide resolved
dbyron0
pushed a commit
to dbyron0/halyard
that referenced
this pull request
Jan 8, 2019
…anonical name (spinnaker#1141) * Add required changes for grouping on canonical name * Fix jinja to allow empty lists * Remove unused comment * Address style comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When using HA mode the sidecar support is hard to configure due to the differing service names. Since the configuration is done per deployment this makes managing multiple sidecars unwieldy.
Change
Add a check for canonical name of the base service if a service specific config is not supplied.
The configuration works as follows:
Check for Service Name configs (spin-clouddriver)
-> if not set check the canonical name (clouddriver)
-> done
Test
Compiled and ran tests, there are no tests for this particular module, cut a custom build and applied changes via service name and canonical name