Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config/secrets): add korkSecrets dependency to halyard-config #1159

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

KathrynLewis
Copy link
Contributor

@KathrynLewis KathrynLewis commented Jan 17, 2019

Part of secrets management project.

Depends on adding kork to spinnaker-dependencies here: https://github.com/spinnaker/spinnaker-dependencies/pull/279/files

spinnaker/spinnaker#3649

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 9bed2d9: feat(config/secrets): add new annotations for secrets in configs

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@lwander lwander merged commit e5f0171 into spinnaker:master Jan 23, 2019
@mrampton mrampton deleted the kork-dependency branch January 25, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants