feat(secrets): clear secret caches at end of each session #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibyom
approved these changes
Mar 15, 2019
|
Added a commit bumping the spinnaker dependencies. Expecting Travis to pass this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure secrets and more importantly the secret temp files are cleaned up at the end of each session. So we're doing that
DaemonTaskin thecleanupResourcesmethod. In order to avoid circular dependencies, we're movingSecretSessionManagerfrom halyard-config to halyard-core. To simplify the caching, we've movedSecretSessionout of halyard and handling all caching in kork instead (see spinnaker/kork#247).(this won't build until spinnakerbot autobumps dependencies)
@dibyom PTAL?