chore(install): Add Arch Linux installation #1251
Conversation
Not a lot of changes, since bash is bash anywhere, but this is a list: * Uses `who` instead of `who -m` that doesn't behave correctly on arch, I guess something different about how loginctl works, but couldn't find anything specific. * Uses pacman to install the needed java/ca packages instead of dpkg. * Removed the migration check, that is specific to past debian packages. * Uses a `sysusers` file to create system groups instead of using `groupadd` as suggested by the packaging guidelines. Tested on Arch and Manjaro, and worked fine. There may be some imcompatibility with other arch based distros but should cover most of the options around.
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
Not a lot of changes, since bash is bash anywhere, but this is a list: * Uses who instead of who -m that doesn't behave correctly on arch, I guess something different about how loginctl works, but couldn't find anything specific. * Uses pacman to install the needed java/ca packages instead of dpkg. * Removed the migration check that was specific to past debian packages. * Uses a sysusers file to create system groups instead of using groupadd as suggested by the packaging guidelines. Still mentions debian for the download location/archives since there's no generic named file to download. Tested on Arch and Manjaro, and worked fine. There may be some imcompatibility with other arch based distros but should cover most of the options around.
coredump
changed the title
There was a problem hiding this comment.
Thanks for the contribution! This is similar enough to the debian install script that I almost want to see if there's a way to just have conditional logic in the script that branches based on the install (not that it's great to have too much logic in bash scripts...)
Some notes on the differences:
whovs.who -m: I left a comment thatwhoamimight just work for bothpacman: This could just be anotherifblock ininstall_java(which already branches on distribution)- migration check: It looks like that's just a no-op if
dpkgis missing, so it might be safe to just let this run anyway for arch linux sysusersvs.groupadd: This could probably just be another branch on the distroID
Let me know your thoughts---my main concern with having this be a completely separate script is that people will forget to update it when they either add features or make Halyard changes that require a change in the install script. So I'd lean a bit towards branching in the same script for that reason, even though it does add a bit of complexity (particularly for a bash script).
This makes the old InstallHalyard less debian/ubuntu centric by adding Arch Linux based distros to it. Moved it to a `linux` directory, following the current standard (there's a `macos` directory) Tested on pristine vagrant images and both install correctly. Should be easy to adapt to other distros.
|
Modified the PR to make it a single script, as @ezimanyi suggested. |
|
This breaks the docs at: |
|
Whoops, I didn't notice in the PR diff that the file was moved as well as changed. I think we should leave this at the original path...while it would be technically more correct to have it in a path called |
|
Moving the script back in #1277. |
Not a lot of changes, since bash is bash anywhere, but this is a list:
whoinstead ofwho -mthat doesn't behave correctly on arch,I guess something different about how loginctl works, but couldn't
find anything specific.
packages.
sysusersfile to create system groups instead of usinggroupaddas suggested by the packaging guidelines.Still mentions debian for the download location/archives since there's no
generic named file to download.
Tested on Arch and Manjaro, and worked fine. There may be some
imcompatibility with other arch based distros but should cover most of
the options around.