fix(gcb): Fix gcb command parameters #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GCB command parameters are camel case, which is inconsistent with all other halyard commands. Fix this now before the feature is live in Spinnaker and users are depending on these.
maggieneterval
approved these changes
May 20, 2019
|
@spinnakerbot cherry-pick 1.20 |
|
Cherry pick successful: #1321 |
spinnakerbot
pushed a commit
that referenced
this pull request
May 20, 2019
The GCB command parameters are camel case, which is inconsistent with all other halyard commands. Fix this now before the feature is live in Spinnaker and users are depending on these.
ezimanyi
pushed a commit
that referenced
this pull request
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GCB command parameters are camel case, which is inconsistent with all other halyard commands. Fix this now before the feature is live in Spinnaker and users are depending on these.