feat(kubernetes): add opt-in livenessProbe with configurable initialD…

[maggieneterval]

…elaySeconds

Closes spinnaker/spinnaker#4023

• Adds two new sub-commands to the hal config deploy edit command, modeled off the code for the vault sub-commands : --liveness-probe-enabled and --liveness-probe-initial-delay-seconds.
• Adds liveness probe configuration to Kubernetes v1 and v2 providers, abstracting logic shared with readiness probes into its own method in each of the three affected classes.
• Adds initialDelaySeconds to manifest probe templates, and removes "readiness" from the name of each since these are now reused by liveness probes.

[maggieneterval]

@plumpy if we could hold the next halyard release until this is merged I would be forever grateful 🙏

[ezimanyi]

📦 🐢 🕐

[davidxia]

@maggieneterval is there a way to tell what Spinnaker version here this will be released as? https://www.spinnaker.io/community/releases/versions/

[maggieneterval]

@davidxia Halyard is actually released separately from Spinnaker, but I expect @plumpy will release Halyard 1.22.0 with this change next week? 🙏

[davidxia]

Ah, that's right. Thanks for explaining. Keep me posted on the release. Is there a page I can see the releases or changelog for halyard?

[maggieneterval]

I will definitely let you know and also comment on the original issue so anyone following knows as well! As far as I know we are not as good about documenting the halyard releases on spinnaker.io, but at least the last commit in each release is documented here: https://github.com/spinnaker/halyard/releases
Generally, I think the #halyard channel in slack is currently the best place to be notified of halyard releases specifically since we don't post about them in #spinnaker-releases.