Skip to content

Commit

Permalink
chore(dependencies): fiatVersion 1.7.0 (#529)
Browse files Browse the repository at this point in the history
fixes a test that broke as a result of coupling the API spec to the
fiat Permissions object. This just fixes the resulting change, but
a proper refactor would be to maybe undo that in favor of something
that translated to and from Map<String, List<String>> to avoid
future breakages if/when additional authorization types are added.
  • Loading branch information
cfieber authored Oct 23, 2019
1 parent 5a335c1 commit 1374553
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 6 deletions.
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Wed Oct 23 19:56:54 UTC 2019
fiatVersion=1.1.0
fiatVersion=1.7.0
enablePublishing=false
spinnakerGradleVersion=7.0.1
korkVersion=6.14.3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class InfoControllerSpec extends Specification {
then:
def actualAccounts = new JsonSlurper().parseText(response.contentAsString);
actualAccounts.size == 1
actualAccounts[0].permissions == [:]
actualAccounts[0].permissions == [READ:[], WRITE:[], CREATE:[], EXECUTE:[]]

}

Expand Down Expand Up @@ -195,7 +195,12 @@ class InfoControllerSpec extends Specification {
{
"name": "jenkins-foo",
"buildServiceProvider": "JENKINS",
"permissions": {}
"permissions": {
"READ": [],
"WRITE": [],
"EXECUTE": [],
"CREATE": []
}
},
{
"name": "jenkins-bar",
Expand All @@ -207,7 +212,9 @@ class InfoControllerSpec extends Specification {
],
"WRITE": [
"group-2"
]
],
"EXECUTE": [ ],
"CREATE": []
}
},
{
Expand All @@ -220,7 +227,9 @@ class InfoControllerSpec extends Specification {
],
"WRITE": [
"group-3"
]
],
"EXECUTE": [ ],
"CREATE": []
}
},
{ "name": "gcbAccount",
Expand All @@ -232,7 +241,9 @@ class InfoControllerSpec extends Specification {
],
"WRITE": [
"group-5"
]
],
"EXECUTE": [ ],
"CREATE": []
}
}
]
Expand Down

0 comments on commit 1374553

Please sign in to comment.