capture R exceptions and display them (#152)

spinnaker · Dec 11, 2017 · 130012e · 130012e
1 parent 9ef083f
commit 130012e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/kayenta-r-mannwhitney/src/main/java/com/netflix/kayenta/r/MannWhitney.java b/kayenta-r-mannwhitney/src/main/java/com/netflix/kayenta/r/MannWhitney.java
@@ -47,9 +47,12 @@ synchronized public MannWhitneyResult eval(MannWhitneyParams params) throws RExe
       re.assign("controlData", params.getControlData());
       re.assign("experimentData", params.getExperimentData());
       String command = params.toCommandString("controlData", "experimentData");
-      REXP result = re.eval(command);
+      REXP result = re.parseAndEval("try(eval(" + command + "),silent=TRUE)");
       if (result == null) {
-        throw new RExecutionException("Failed to get a result from R for Mann-Whitney test");
+        throw new RExecutionException("Failed to get a result from R for Mann-Whitney test. command:" + command);
+      }
+      if (result.inherits("try-error")) {
+        throw new RExecutionException("Failed to get a result from R for Mann-Whitney test. command: " + command + ", error: " + result.asString());
       }
 
       RList list = result.asList();

diff --git a/kayenta-r-mannwhitney/src/main/java/com/netflix/kayenta/r/MannWhitneyParams.java b/kayenta-r-mannwhitney/src/main/java/com/netflix/kayenta/r/MannWhitneyParams.java
@@ -33,20 +33,6 @@ public class MannWhitneyParams {
   @Getter
   private double[] experimentData;
 
-  String toCommandString() {
-    StringBuilder ret = new StringBuilder();
-    ret.append("wilcox.test(");
-    appendVector(ret, controlData);
-    ret.append(",");
-    appendVector(ret, experimentData);
-    ret.append(",conf.int=TRUE,mu=");
-    ret.append(mu);
-    ret.append(",conf.level=");
-    ret.append(confidenceLevel);
-    ret.append(")");
-    return ret.toString();
-  }
-
   String toCommandString(String controlName, String experimentName) {
     String ret = "wilcox.test(" + experimentName + "," + controlName;
     ret += ",conf.int=TRUE,mu=" + mu;