feat(judges): Add visible property to judge interface and default t…

…o false. (#87)
spinnaker · Sep 18, 2017 · 992a9c0 · 992a9c0
1 parent 1863ce6
commit 992a9c0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/kayenta-core/src/main/java/com/netflix/kayenta/canary/CanaryJudge.java b/kayenta-core/src/main/java/com/netflix/kayenta/canary/CanaryJudge.java
@@ -21,9 +21,13 @@
 
 import java.util.List;
 
-public interface CanaryJudge {
-  String getName();
-  CanaryJudgeResult judge(CanaryConfig canaryConfig,
-                          CanaryClassifierThresholdsConfig orchestratorScoreThresholds,
-                          List<MetricSetPair> metricSetPairList);
+public abstract class CanaryJudge {
+  public boolean isVisible() {
+    return false;
+  }
+
+  abstract public String getName();
+  abstract public CanaryJudgeResult judge(CanaryConfig canaryConfig,
+                                          CanaryClassifierThresholdsConfig orchestratorScoreThresholds,
+                                          List<MetricSetPair> metricSetPairList);
 }
diff --git a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/NetflixACAJudge.scala b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/NetflixACAJudge.scala
@@ -38,6 +38,8 @@ case class Metric(name: String, values: Array[Double], label: String)
 class NetflixACAJudge extends CanaryJudge with StrictLogging {
   private final val judgeName = "NetflixACAJudge-v1.0"
 
+  override def isVisible: Boolean = true
+
   override def getName: String = judgeName
 
   override def judge(canaryConfig: CanaryConfig,

diff --git a/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/RandomDummyJudge.scala b/kayenta-judge/src/main/scala/com/netflix/kayenta/judge/RandomDummyJudge.scala
@@ -24,7 +24,7 @@ import com.netflix.kayenta.metrics.MetricSetPair
 import org.springframework.stereotype.Component
 
 @Component
-class RandomDummyJudge extends CanaryJudge{
+class RandomDummyJudge extends CanaryJudge {
   private final val _judgeName = "dredd-v1.0"
 
   override def getName: String = _judgeName