Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typeahead/prometheus): Consider account name when querying metadata. #598

Merged
merged 1 commit into from
Jul 24, 2019
Merged

fix(typeahead/prometheus): Consider account name when querying metadata. #598

merged 1 commit into from
Jul 24, 2019

Conversation

duftler
Copy link
Collaborator

@duftler duftler commented Jul 24, 2019

No description provided.

@duftler duftler mentioned this pull request Jul 24, 2019
Closed
maggieneterval
maggieneterval approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📛 ❓ 💻

@maggieneterval maggieneterval merged commit 67e369f into spinnaker:master Jul 24, 2019
@maggieneterval maggieneterval mentioned this pull request Jul 25, 2019
Merged
@maggieneterval
Copy link
Contributor

@spinnakerbot cherry-pick 1.15

@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit 67e369f) with exit code 1:

error: could not apply 67e369f... fix(typeahead/prometheus): Consider account name when querying metadata. (#598)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

@maggieneterval maggieneterval mentioned this pull request Jul 25, 2019
Merged
maggieneterval pushed a commit to maggieneterval/kayenta that referenced this pull request Jul 25, 2019
@maggieneterval
fix(typeahead/prometheus): Consider account name when querying metada…
2eec1b3 
…ta. (spinnaker#598)
@maggieneterval maggieneterval mentioned this pull request Jul 25, 2019
Merged
fieldju pushed a commit that referenced this pull request Aug 1, 2019
@maggieneterval @fieldju
fix(typeahead/prometheus): Consider account name when querying metada…
6a3c60f 
…ta. (#598) (#601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggieneterval maggieneterval maggieneterval approved these changes

Assignees
No one assigned
Labels
target-release/1.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duftler @maggieneterval @spinnakerbot