Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secrets/gcs): Bumping orca dep for pulling gcs secrets module #620

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

german-muzquiz
Copy link
Contributor

Bumping orca dependency to include new kork-secrets-gcp module.
PR introducing GcsSecretsEngine: spinnaker/kork#380

Fixes: spinnaker/spinnaker#4668

@duftler
Copy link
Collaborator

duftler commented Oct 14, 2019

The changes look reasonable to me.

Can you please indicate how you've tested kayenta to ensure it still functions properly with the latest orca version?

In the past, we have encountered subtle changes to orca/keiko that required kayenta changes when upgrading.

@fieldju
Copy link
Collaborator

fieldju commented Oct 14, 2019

The changes look reasonable to me.

Can you please indicate how you've tested kayenta to ensure it still functions properly with the latest orca version?

In the past, we have encountered subtle changes to orca/keiko that required kayenta changes when upgrading.

With @Aloren's change to the build process a set of integration tests now run on every PR.
So I can say that Kayenta still functions end to end with at least Graphite and Prometheus.

https://travis-ci.org/spinnaker/kayenta/builds/597037661?utm_source=github_status&utm_medium=notification

@duftler
Copy link
Collaborator

duftler commented Oct 14, 2019

With @Aloren's change to the build process a set of integration tests now run on every PR.
So I can say that Kayenta still functions end to end with at least Graphite and Prometheus.

https://travis-ci.org/spinnaker/kayenta/builds/597037661?utm_source=github_status&utm_medium=notification

Works for me.

LGTM.

@duftler duftler merged commit d1edf69 into spinnaker:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Extend the secrets-feature to cover GCS as well (only S3 now)
4 participants