Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(artifacts): demonstrate that S3ArtifactStoreGetter.get does not … #1178

Merged
merged 1 commit into from
Apr 27, 2024
Merged

test(artifacts): demonstrate that S3ArtifactStoreGetter.get does not … #1178

merged 1 commit into from
Apr 27, 2024

Commits on Apr 26, 2024

  1. test(artifacts): demonstrate that S3ArtifactStoreGetter.get does not … 

    …use AuthenticatedRequest.getSpinnakerUser

when authenticating with the permission evaluator.  It uses
SecurityContextHolder.getContext() which may be null depending how the context is
propagated across threads. This is the case in some scenarios during pipeline execution in
orca (e.g. using #fetchReference in an Evaluate Variables stage).
    @dbyron-sf
    dbyron-sf committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1c74ba7 View commit details
    Browse the repository at this point in the history