chore(kork-aws): Converting groovy classes to java #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyrschabu
commented
Jul 8, 2019
|
|
||
| import java.text.SimpleDateFormat | ||
|
|
||
| class RemoteCredentialsSupport { |
There was a problem hiding this comment.
Keeping this class in groovy because of sshoogr/sshoogr#81
|
We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:
See our server-side commit conventions here. |
|
looks like a couple of the Bastion files that were converted to java got left in the |
cfieber
approved these changes
Jul 8, 2019
jeyrschabu
force-pushed
the
groovylessly-kork-aws
branch
from
0b3d8ed
to
8a40159
Compare
- Additional: minor refactor to extract ssh dsl bits to a class
jeyrschabu
force-pushed
the
groovylessly-kork-aws
branch
from
8a40159
to
484fbf9
Compare
claymccoy
pushed a commit
to claymccoy/kork
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteCredentialsSupport.