feat(sql): Support for multiple SQL data sources #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
srekapalli
commented
Nov 27, 2019
srekapalli
commented
- Conditionally add secondary liquibase target if configured.
- Conditionally add secondary JOOQ (DSLContext) to target a different dialect than the primary source. If two connection pools exist and they both are of same dialect we will not create secondary JOOQ bean. (eg: application having 2 pools against the same datasource will not need a secondary JOOQ)
- Configuration is backward compatible for the most part. Applications will need to wire up the JOOQ and pool as applicable on the app side of things.
- Tests exercise taking in the new sql config and verifies the bean existence as expected.
cfieber
approved these changes
Nov 27, 2019
kork-sql/src/main/kotlin/com/netflix/spinnaker/kork/sql/config/DefaultSqlConfiguration.kt
Outdated
Show resolved
Hide resolved
kork-sql/src/main/kotlin/com/netflix/spinnaker/kork/sql/config/SecondaryPoolDialectCondition.kt
Show resolved
Hide resolved
jonsie
reviewed
Nov 27, 2019
kork-sql/src/main/kotlin/com/netflix/spinnaker/kork/sql/config/SqlProperties.kt
Outdated
Show resolved
Hide resolved
jonsie
approved these changes
Nov 27, 2019
This was referenced Dec 4, 2019
claymccoy
pushed a commit
to claymccoy/kork
that referenced
this pull request
Mar 3, 2020
Since Bitbuckets Server hooks are different from Bitbucket Cloud, now also add support for the former, so can be triggered with on-prem. This now also handles Bitbucket Server ping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.