chore(dependencies): Upgrade org.testng:testng to resolve vulnerability #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SONATYPE-2019-0115 org.testng:testng is transitively introduced by org.codehaus.groovy:groovy-testng (part of groovy-all)
|
After applying the fix, gate dependency insight |
|
Clouddriver dependency insight: |
dbyron-sf
reviewed
Sep 3, 2021
| @@ -168,6 +168,7 @@ dependencies { | |||
| api("org.springframework.security.oauth.boot:spring-security-oauth2-autoconfigure:2.1.5.RELEASE") | |||
| api("org.springframework.security.extensions:spring-security-saml-dsl-core:1.0.5.RELEASE") | |||
| api("org.springframework.security.extensions:spring-security-saml2-core:1.0.9.RELEASE") | |||
| api("org.testng:testng:7.4.0") // TODO: remove this with upgrade of spring-boot version to 2.5.0 or with upgrade of groovy-all to 3.0.8 | |||
There was a problem hiding this comment.
As background, groovy 3.0.7 brings in testng 7.3.0 and groovy 3.0.8 brings in 7.4.0 via [this commit].(apache/groovy@c187b71).
spring boot 2.5.0 brings in groovy-testng 3.0.8, where spring boot 2.4.9 brings in groovy-testng 2.5.14. It's in theory possible that some later 2.4.x could move to groovy-testng 3.0.8, but given this 2.5 release note, that seems unlikely.
|
I believe https://snyk.io/vuln/SNYK-JAVA-ORGTESTNG-174823 motivates updating testng to at least 7.0.0 and testng-team/testng#2406 motivates going to 7.4.0 |
|
I'm a little nervous about such a big jump in testng (from 6.13.1 to 7.4.0), but given that I only see fixes, new features, and removal of deprecated functions in https://github.com/cbeust/testng/blob/7.4.0/CHANGES.txt (i.e. nothing obviously breaking) and https://github.com/cbeust/testng/blob/7.4.0/build.gradle.kts#L108 show that testng tests against groovy 2.4 (i.e. not 3.x), I'm OK with this. |
dbyron-sf
approved these changes
Sep 3, 2021
|
@dbyron-sf Thanks for elaborate supporting details. |
3 tasks
6 tasks
ylebedeva
pushed a commit
to ylebedeva/kork
that referenced
this pull request
May 3, 2022
…ty (spinnaker#894) SONATYPE-2019-0115 org.testng:testng is transitively introduced by org.codehaus.groovy:groovy-testng (part of groovy-all) Co-authored-by: j-sandy <jsandy>
richard-timpson
pushed a commit
to richard-timpson/kork
that referenced
this pull request
May 3, 2023
…innaker#11) chore(dependencies): Upgrade org.testng:testng to resolve vulnerability (spinnaker#894) SONATYPE-2019-0115 org.testng:testng is transitively introduced by org.codehaus.groovy:groovy-testng (part of groovy-all) Co-authored-by: j-sandy <jsandy> Co-authored-by: Sandesh <sandeshjainhyd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONATYPE-2019-0115
org.testng:testng is transitively introduced by org.codehaus.groovy:groovy-testng (part of groovy-all)