fix(security): set platform restriction on log4j #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps log4j platform restriction. Though the core lib is NOT included in dependencies, better safe than sorry...
j-sandy
reviewed
Dec 14, 2021
| // Log4shell safeguard. Per analysis, log4j-core is not included in dependencies, but this would prevent transitive inclusion of it by extension | ||
| // platforms. Doing 2.16.0 which completely removes message lookups AND sets jndi to disabled by default | ||
|
|
||
| api(platform("org.apache.logging.log4j:log4j-bom:2.16.0")) |
There was a problem hiding this comment.
This behavior is also disabled by default in 2.15.0 as mentioned here . I hope we should have a valid reason to bump up for 2.16.0.
There was a problem hiding this comment.
- It's good to be on latest releases as much as possible or makes sense.
- 2.16 makes jdni lookups disabled by default entirely vs. just fixing the parsing in log messages. As such it's MUCH more secure and recommended.
Either of the above reasons would be justification for bumping to 2.16.
There was a problem hiding this comment.
There was another CVE published today (a medium one) for 2.15.0, so using 2.16.0 makes sense.
dbyron-sf
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Thanks for this @jasonmcintosh . Planning to tag kork after this goes in.
6 tasks
ylebedeva
pushed a commit
to ylebedeva/kork
that referenced
this pull request
May 3, 2022
Bumps log4j platform restriction. Though the core lib is NOT included in dependencies, better safe than sorry...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps log4j platform restriction. Though the core lib is NOT included in dependencies, better safe than sorry...