fix(dependency): Issue of brave-bom version conflict resolution while enforcing dependencies from kork-bom in spinnaker services. #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enforcing dependencies from kork-bom in spinnaker services. Refer issues : spinnaker/spinnaker#6623 spinnaker/spinnaker#6624 The issue of brave-bom conflict was observed in all the spinnaker services while enforcing dependencies from kork-bom. In all the spinnaker services, io.zipkin.brave dependency is introduced by the means of maven imported kork-bom. After introduction of enforcedPlatform, it adhere to the version of brave package provided by Hoxton.SR4, because io.zipkin.brave:brave-bom is not part of spinnaker-dependencies.gradle in kork and its just a constraint here. To fix this issue, introduced brave-bom dependency with desired version and removed it from constraint section under spinnaker-dependencies.gradle api(platform("io.zipkin.brave:brave-bom:${versions.brave}")) The desired version of brave-bom (5.12.3) is supported by org.springframework.cloud:spring-cloud-dependencies:Hoxton.SR5. It can be considered to exclude this dependency after upgrade of Hoxton.SR5.
dbyron-sf
approved these changes
Mar 23, 2022
11 tasks
6 tasks
ylebedeva
pushed a commit
to ylebedeva/kork
that referenced
this pull request
May 3, 2022
… enforcing dependencies from kork-bom in spinnaker services. (spinnaker#943) Refer issues : spinnaker/spinnaker#6623 spinnaker/spinnaker#6624 The issue of brave-bom conflict was observed in all the spinnaker services while enforcing dependencies from kork-bom. In all the spinnaker services, io.zipkin.brave dependency is introduced by the means of maven imported kork-bom. After introduction of enforcedPlatform, it adhere to the version of brave package provided by Hoxton.SR4, because io.zipkin.brave:brave-bom is not part of spinnaker-dependencies.gradle in kork and its just a constraint here. To fix this issue, introduced brave-bom dependency with desired version and removed it from constraint section under spinnaker-dependencies.gradle api(platform("io.zipkin.brave:brave-bom:${versions.brave}")) The desired version of brave-bom (5.12.3) is supported by org.springframework.cloud:spring-cloud-dependencies:Hoxton.SR5. It can be considered to exclude this dependency after upgrade of Hoxton.SR5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer issues :
spinnaker/spinnaker#6623
spinnaker/spinnaker#6624
The issue of brave-bom conflict was observed in all the spinnaker services while enforcing dependencies from kork-bom.
In all the spinnaker services, io.zipkin.brave dependency is introduced by the means of maven imported kork-bom. After introduction of enforcedPlatform, it adhere to the version of brave package provided by Hoxton.SR4, because io.zipkin.brave:brave-bom is not part of spinnaker-dependencies.gradle in kork and its just a constraint here.
To fix this issue, introduced brave-bom dependency with desired version and removed it from constraint section under spinnaker-dependencies.gradle
api(platform("io.zipkin.brave:brave-bom:${versions.brave}"))
The desired version of brave-bom (5.12.3) is supported by org.springframework.cloud:spring-cloud-dependencies:Hoxton.SR5. It can be considered to exclude this dependency after upgrade of Hoxton.SR5.