-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dependencies): Upgrade Spring Boot to 2.3.12 #946
Conversation
Upgraded following dependencies along with spring boot to 2.3.12.RELEASE: groovy-all:2.5.14 jooq:3.13.6 Cleaned up following dependencies and constraints as being part of spring boot 2.3.12.RELEASE: spring-framework-bom assertj-core postgresql While building kork with upgrade, faced errors like: Task :kork-core:compileJava /kork/kork-core/src/main/java/com/netflix/spinnaker/kork/lock/LockManager.java:19: error: package com.fasterxml.jackson.annotation does not exist import com.fasterxml.jackson.annotation.JsonCreator; ^ /kork/kork-core/src/main/java/com/netflix/spinnaker/kork/lock/LockManager.java:20: error: package com.fasterxml.jackson.annotation does not exist import com.fasterxml.jackson.annotation.JsonInclude; ^ /kork/kork-core/src/main/java/com/netflix/spinnaker/kork/lock/LockManager.java:21: error: package com.fasterxml.jackson.annotation does not exist import com.fasterxml.jackson.annotation.JsonProperty; ^ To resolve errors, introduced explicit implementation of com.fasterxml.jackson.core:jackson-annotations and com.fasterxml.jackson.core:jackson-databind in kork-core.gradle. And com.fasterxml.jackson.core:jackson-databind in kork-jedis.gradle
The kork changes have been tested by publishing local maven pom of kork-bom with each spinnaker service. No issues found.
Assertj-core echo:
|
Assertj-core fiat:
Assertj-core front50:
|
Assertj-core gate:
Assertj-core igor:
|
Assertj-core orca:
Assetj-core rosco:
|
postgresql clouddriver:
postgresql fiat:
postgresql front50:
postgresql orca:
|
spring clouddriver:
spring echo:
spring fiat:
spring front50:
spring gate:
spring halyard:
spring igor:
spring orca:
spring rosco:
|
Have you considered upgrading spring cloud to the level that it is consistent with spring boot 2.3.12? |
@claymccoy Thanks for bringing this point on table. I wish to have it in this PR, but following are the few reasons, prefer to take spring-cloud upgrade as a subsequent task/PR after spring-boot upgrade:
|
Upgraded following dependencies along with spring boot to 2.3.12.RELEASE:
groovy-all:2.5.14
jooq:3.13.6
Cleaned up following dependencies and constraints as being part of spring boot 2.3.12.RELEASE:
spring-framework-bom:5.2.15.RELEASE
assertj-core:3.16.1
postgresql:42.2.20
While building kork with upgrade, faced errors like:
Task :kork-core:compileJava
/kork/kork-core/src/main/java/com/netflix/spinnaker/kork/lock/LockManager.java:19: error: package com.fasterxml.jackson.annotation does not exist
import com.fasterxml.jackson.annotation.JsonCreator;
^
/kork/kork-core/src/main/java/com/netflix/spinnaker/kork/lock/LockManager.java:20: error: package com.fasterxml.jackson.annotation does not exist
import com.fasterxml.jackson.annotation.JsonInclude;
^
/kork/kork-core/src/main/java/com/netflix/spinnaker/kork/lock/LockManager.java:21: error: package com.fasterxml.jackson.annotation does not exist
import com.fasterxml.jackson.annotation.JsonProperty;
^
To resolve errors, introduced explicit implementation of com.fasterxml.jackson.core:jackson-annotations and com.fasterxml.jackson.core:jackson-databind in kork-core.gradle.
And com.fasterxml.jackson.core:jackson-databind in kork-jedis.gradle