fix(executionprocessor): add @Order to execution processors #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows an execution processor to specify order of invocation. This is useful (/ needed) when an preprocessor needs to operate on a fully instantiated pipeline. If the pipeline is templated it won't be fully instantiated till the templatepreprocessor runs.
robzienert
reviewed
May 16, 2019
| import org.springframework.stereotype.Component | ||
| import javax.annotation.Nonnull | ||
| import javax.annotation.PostConstruct | ||
|
|
||
| @Component("pipelineTemplatePreprocessor") | ||
| @Order(1) |
There was a problem hiding this comment.
I don't think we want orders to be the same. Sounds like a neat recipe for indeterminate behavior.
There was a problem hiding this comment.
it's what it is now anyway, but yeah, i can change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an execution processor to specify order of invocation.
This is useful (/ needed) when an preprocessor needs to operate on a
fully instantiated pipeline. If the pipeline is templated it won't be
fully instantiated till the templatepreprocessor runs.