perf(sql): Add indexes on correlated execution ids for faster deletes #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
force-pushed
the
perf-correlationids
branch
from
f7b8e56
to
92135f8
Compare
robzienert
force-pushed
the
perf-correlationids
branch
from
92135f8
to
7dd5ddd
Compare
asher
reviewed
May 17, 2019
| it.delete(table("correlation_ids")).where(field(correlationField).eq(ulid)).execute() | ||
| it.delete(type.stagesTableName).where(field("execution_id").eq(ulid)).execute() | ||
| it.delete(table("correlation_ids")).where(field("id").eq( | ||
| it.select(field("id")).from("correlation_ids") |
There was a problem hiding this comment.
I think the lists of correlation_ids.id and pipeline|orchestration_stages.ids should be fetched as individual queries outside of the transactional, followed by a transaction that deletes from the 3 tables by primary key with a single execute().
robzienert
force-pushed
the
perf-correlationids
branch
from
7dd5ddd
to
c942796
Compare
asher
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.