Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bakery): Making bakery service selectable by parameters #2973

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

jeyrschabu
Copy link
Contributor

  • Using kork v2 selector to shard the bakery based on parameters

@jeyrschabu
Copy link
Contributor Author

Allows sharding the bakery based on parameters. Also supports current v1 selector fields including application, authenticatedUser, regex.

bakery:
  baseUrl: http://bakery.test.netflix.net
  roscoApisEnabled: false
  baseUrls:
  - baseUrl: https://rosco-test-us-west-2.spinnaker.test.netflix.net
    priority: 2
    config:
      roscoApisEnabled: true
    parameters:
    - name: region
      values:
      - us-west-2
    - name: authenticatedUser
    values:
    - regex:^[a..e].+@netflix.com

  - baseUrl: https://rosco-test-us-east-1.spinnaker.test.netflix.net
    priority: 3
    config:
      roscoApisEnabled: true
    parameters:
    - name: region
      values:
      - us-east-1

@jeyrschabu jeyrschabu requested a review from asher June 10, 2019 23:22
Copy link
Contributor

@asher asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

- Using kork v2 selector to shard the bakery based on parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants