fix(jobs): fix race condition in override #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a case where parameter overrides would override the base job configuration as well as the job in the context. this is because the previous implementation would assign a reference to `context[it]` instead of a copy. when the parameter overriding was done it would not only modify the fields in context but also the base configuration. this presented itself when running > 1 job in parallel. by focing a new copy (via `converValue` for simplicity) we get a fresh object reference we can assign. fixes spinnaker/spinnaker#4487
ethanfrogers
force-pushed
the
fix-preconfigured-job-race
branch
from
d5043ad
to
67af8db
Compare
|
@spinnakerbot cherry-pick 1.14 |
|
Cherry pick failed: Command failed (cherry pick commit e66bbc9) with exit code 1: |
ethanfrogers
added a commit
to ethanfrogers/orca
that referenced
this pull request
Jun 18, 2019
fixes a case where parameter overrides would override the base job configuration as well as the job in the context. this is because the previous implementation would assign a reference to context[it] instead of a copy. when the parameter overriding was done it would not only modify the fields in context but also the base configuration. this presented itself when running > 1 job in parallel. by focing a new copy (via converValue for simplicity) we get a fresh object reference we can assign. Note - manual patch from spinnaker#2988
This was referenced Jun 18, 2019
ethanfrogers
added a commit
that referenced
this pull request
Jun 18, 2019
fixes a case where parameter overrides would override the base job configuration as well as the job in the context. this is because the previous implementation would assign a reference to context[it] instead of a copy. when the parameter overriding was done it would not only modify the fields in context but also the base configuration. this presented itself when running > 1 job in parallel. by focing a new copy (via converValue for simplicity) we get a fresh object reference we can assign. Note - manual patch from #2988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a case where parameter overrides would override the base job
configuration as well as the job in the context. this is because the
previous implementation would assign a reference to
context[it]instead of a copy. when the parameter overriding was done it would not
only modify the fields in context but also the base configuration. this
presented itself when running > 1 job in parallel. by focing a new copy
(via
converValuefor simplicity) we get a fresh object reference wecan assign.
fixes spinnaker/spinnaker#4487