Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gce): Add StatefullyUpdateBootDisk{Task,Stage} #3007

Merged
merged 4 commits into from
Jun 26, 2019
Merged

feat(gce): Add StatefullyUpdateBootDisk{Task,Stage} #3007

merged 4 commits into from
Jun 26, 2019

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Jun 25, 2019

No description provided.

ezimanyi
ezimanyi approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things inline, otherwise looks good!

...etflix/spinnaker/orca/clouddriver/pipeline/providers/gce/StatefullyUpdateBootImageStage.java Outdated Show resolved Hide resolved
...om/netflix/spinnaker/orca/clouddriver/tasks/providers/gce/StatefullyUpdateBootImageTask.java Show resolved Hide resolved
...etflix/spinnaker/orca/clouddriver/pipeline/providers/gce/StatefullyUpdateBootImageStage.java Show resolved Hide resolved
@ezimanyi ezimanyi merged commit 4781dc4 into spinnaker:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plumpy @ezimanyi @spinnakerbot