fix(pipelines): an execution only starts one dep pipeline once #3070
Conversation
There was a problem hiding this comment.
looks good to me, like @ajordens said, i am a bit confused how the race is avoided when two instances have the same correlation id almost at the same time... but that's a separate problem
|
There are a couple edge cases that this PR doesn't quite cover. I think creating a correlation id consisting of the parentId + childId + timestamp will be unique enough to support (a) multiple child pipelines and (b) restarts. |
|
@ajordens updated to fix this other cases. Thanks for pointing them out! |
| @@ -85,7 +85,8 @@ class DependentPipelineStarter implements ApplicationContextAware { | |||
| parentExecution : parentPipeline, | |||
| parentPipelineStageId: parentPipelineStageId, | |||
| parameters : [:], | |||
| strategy : suppliedParameters.strategy == true | |||
| strategy : suppliedParameters.strategy == true, | |||
| correlationId : parentPipeline.id + "_" + pipelineConfig.id + "_" + parentPipeline.startTime | |||
There was a problem hiding this comment.
why pipelineConfig.id? would that change from execution to execution?
There was a problem hiding this comment.
A parent pipeline might have multiple child pipelines that trigger on completion.
Start time accounts for a restart, since we change the start time if the pipeline restarts.
If a pipeline that triggers a downstream pipeline is canceled, and that downstream pipeline doesn't limit concurrent pipelines, you can get two duplicate downstream pipeline executions.
This PR adds the
parent execution idas acorrelationIdso that the downstream pipeline only run once.