fix(conditions): Only pause pipeline deploys #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeyrschabu
commented
Sep 13, 2019
jeyrschabu
commented
- Pausing deployments should only apply to pipelines
- Orchestrations should be ignored
jeyrschabu
force-pushed
the
pause-pipelines-only
branch
from
b123f31
to
f7ec852
Compare
|
This PR ensures that pausing deployments only applies to pipelines and ignore orchestrations. |
robzienert
approved these changes
Sep 13, 2019
| @@ -48,7 +49,9 @@ public ConditionAwareDeployStagePreprocessor( | |||
|
|
|||
| @Override | |||
| public boolean supports(Stage stage) { | |||
| return true; | |||
| // Restricting pausing deployments to Pipeline executions only | |||
There was a problem hiding this comment.
Suggested change
| // Restricting pausing deployments to Pipeline executions only | |
| // Restrict pausing deployments to Pipeline executions only |
- Pausing deployments should only apply to pipelines - Orchestrations should be ignored
jeyrschabu
force-pushed
the
pause-pipelines-only
branch
from
f7ec852
to
f2607cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.