fix(monitored deploy): send complete notification on failure #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploy fails we need to sent completion notification to the deployement monitor
Added ability to shrink cluster at the end of deploy (same as red/black, with `maxRemainingAsgs` param)
|
@dreynaud I also added a shrinky stage while i was at it |
dreynaud
reviewed
Sep 30, 2019
| MonitoredDeployStageData stageData = parent.mapTo(MonitoredDeployStageData.class) | ||
| if (stageData.deploymentMonitor.id) { | ||
| def evalContext = stageData.getChildStageContext() | ||
| MonitoredDeployInternalStageData internalStageData = new MonitoredDeployInternalStageData() |
There was a problem hiding this comment.
is there anything there to indicate that the deployment failed?
There was a problem hiding this comment.
not yet... there will be! for now, I just want to unblock a use case
https://github.com/spinnaker/orca/blob/master/orca-deploymentmonitor/src/main/java/com/netflix/spinnaker/orca/deploymentmonitor/models/DeploymentCompletedRequest.java#L35
dreynaud
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploy fails we need to sent completion notification to the deployment monitor