fix(test): Fix flaky queue integration test #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test are starting to fail quite frequently with an assertion failure "Pipeline did not complete". This is because we assert that an execution has started within 5 seconds of requesting it, which appears to fail frequently when running in constrained CPU environments. Double the timeout to 10 seconds to alleviate the issue, though a better fix would probably be to avoid having an arbitrary timeout at all. (Perhaps the test function would wait until the queue is quiescent before proceeding?)
asher
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
I like your idea for a better fix, I think @marchello2000 had mentioned a similar idea.
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
The test are starting to fail quite frequently with an assertion failure "Pipeline did not complete". This is because we assert that an execution has started within 5 seconds of requesting it, which appears to fail frequently when running in constrained CPU environments. Double the timeout to 10 seconds to alleviate the issue, though a better fix would probably be to avoid having an arbitrary timeout at all. (Perhaps the test function could wait until the queue is quiescent before proceeding?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test are starting to fail quite frequently with an assertion failure "Pipeline did not complete". This is because we assert that an execution has started within 5 seconds of requesting it, which appears to fail frequently when running in constrained CPU environments.
Double the timeout to 10 seconds to alleviate the issue, though a better fix would probably be to avoid having an arbitrary timeout at all. (Perhaps the test function would wait until the queue is quiescent before proceeding?)