fix(pipelinetemplate): Add template variables to module tag #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to documentation, the module tag should be able to use variables both from the template and variables scoped strictly to the module, however only the latter was the case. Fixed by adding the template variables to the render context.
|
@spinnaker/oss-approvers PTAL 🙂 |
|
Needs tests. |
robzienert
approved these changes
Mar 20, 2020
robzienert
added
ready to merge
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…r#3493) * fix(pipelinetemplate): Add template variables to module tag According to documentation, the module tag should be able to use variables both from the template and variables scoped strictly to the module, however only the latter was the case. Fixed by adding the template variables to the render context. * Added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to documentation, the module tag should be able to use variables both from the pipeline template and variables scoped strictly to the module, however only the latter was the case. Fixed by adding the template variables to the render context.