fix(artifacts): Stop copying expectedArtifactIds to child pipelines #4404
Conversation
This commit partially reverts spinnaker#4397. It broke some pipelines for a team that had a CI stage that created more artifacts with the same name as the expected artifact from the original trigger, and then had a pipeline stage. The result was that the child pipeline was triggered with multiple artifacts with the same name (but different version numbers), and then failed to start because the artifact resolver matched multiple artifacts instead of exactly one. Turns out the changes in DependentPipelineStarter wasn't really needed to fix the issue that spinnaker#4397 tried to solve, so I'm reverting them.
|
@dbyron-sf This is getting ridiculous, but I have another fix I need you to look at! Sorry 😅
|
The feature that copied expected artifact from parent to child pipeline was reverted in https://spinnaker/orca/pull/4404. Removing it from the release notes as well.
The feature that copied expected artifact from parent to child pipeline was reverted in spinnaker/orca#4404. Removing it from the release notes as well.
|
This does make me wonder if there's a different kind of test that we could use to verify this behavior. I haven't looked to see if anything like this exists...do you know? Somewhere to define a pipeline that executes another pipeline, or something? |
The feature that copied expected artifact from parent to child pipeline was reverted in spinnaker/orca#4404. Removing it from the release notes as well.
|
|
Yeah, I was thinking of more like an integration test, but the test here is good for me. |
…pinnaker#4404) This commit partially reverts spinnaker#4397. It broke some pipelines for a team that had a CI stage that created more artifacts with the same name as the expected artifact from the original trigger, and then had a pipeline stage. The result was that the child pipeline was triggered with multiple artifacts with the same name (but different version numbers), and then failed to start because the artifact resolver matched multiple artifacts instead of exactly one. Turns out the changes in DependentPipelineStarter wasn't really needed to fix the issue that spinnaker#4397 tried to solve, so I'm reverting them.
This commit partially reverts #4397. It broke some pipelines for a team that had a CI stage that created more artifacts with the same name as the expected artifact from the original trigger, and then had a pipeline stage. The result was that the child pipeline was triggered with multiple artifacts with the same name (but different version numbers), and then failed to start because the artifact resolver matched multiple artifacts instead of exactly one. Turns out the changes in DependentPipelineStarter wasn't really needed to fix the issue that #4397 tried to solve, so I'm reverting them.