Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty list template response #367

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

FrancoisPoinsot
Copy link
Contributor

When running spin pipeline-template list I was receiving an empty list
This is because the path of the request looked like that

/gate/v2/pipelineTemplates?scopes=%26%5B%5D

the charactere %26%5B%5D decodes to &[]
Technically we could say the issue comes from parameterToString in client.go, and that function should handle receiving a pointer to an array better.

But since this part is generated, here is a fix on the command layer.
To send an array instead of a pointer to an array

@spinnakerbot
Copy link

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

pass the scope parameter as an array instead of pointer to array
Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI could seriously use tests, but :) Looks like a good fix in this case ;)

@jasonmcintosh jasonmcintosh added the ready to merge Approved and Reviewed and ready for merge label Jul 26, 2023
@mergify mergify bot added the auto merged label Jul 26, 2023
@mergify mergify bot merged commit eb20fb8 into spinnaker:master Jul 26, 2023
5 checks passed
@FrancoisPoinsot FrancoisPoinsot deleted the fix-list-scope branch July 26, 2023 15:46
@nandak522
Copy link

@jasonmcintosh Any idea when is 1.31 release going to happen ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged ready to merge Approved and Reviewed and ready for merge target-release/1.31
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants