groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy #5836
Comments
|
@ezimanyi may be able to shed some light on the artifact behavior here. |
|
Here is the stack trace:
|
|
@ezimanyi I got past the error above. The config artifacts were returning a HashMap (not sure if that's a groovy behavior vs java). Anyhow, I converted the HashMap to Artifact object (from kork project) and orca is not failing anymore. P.S. It's working now with my fix, I successfully deployed. I'll submit my code change later. |
|
@guido9j : Thanks for the update, and figuring this out! It does indeed look like the change in #spinnaker/orca#3008 did not correctly account for whether the Please do submit your fix for this, and feel free to tag me on the PR! |
groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact.
…rencing github config artifact for GAE deploy - spinnaker/spinnaker#5836 (#3739) * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact.' fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 * Change to objectMapper * Removed left over Slf4j lines
…rencing github config artifact for GAE deploy - spinnaker/spinnaker#5836 (#3739) * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact.' fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 * Change to objectMapper * Removed left over Slf4j lines (cherry picked from commit ebb04d2)
…rencing github config artifact for GAE deploy - spinnaker/spinnaker#5836 (#3739) (#3757) * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact.' fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 * Change to objectMapper * Removed left over Slf4j lines (cherry picked from commit ebb04d2) Co-authored-by: guido9j <james_guido@homedepot.com>
* fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com>
* fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com> (cherry picked from commit 4a26d90)
* fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com> (cherry picked from commit 4a26d90)
… (#3774) * fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com> (cherry picked from commit 4a26d90) Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
…3772) (#3775) * test(appengine): Add tests demonstrating AppEngine artifact bug (#3772) * fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com> (cherry picked from commit 4a26d90) * test(appengine): Fix incorrect class names and imports A refactor between 1.19 and 1.20 changed a lot of class names and import paths, so the backport didn't apply cleanly. This commit updates the (non-compiling) backport so that it refers to the classes as they exist on the 1.19 branch. Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
|
@ezimanyi : Now that this issue been resolved. Am I supposed to close this issue? (actually, I don't think I can close it) Never mind! I see you are working on test cases. Thanks |
|
@guido9j : I ended up merging the test cases, so I think this can be closed. Thanks for following up! |
…naker#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact.
…naker#3772) * fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (spinnaker#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com>
Issue Summary:
groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy
Cloud Provider(s):
App Engine
Environment:
GCP
Feature Area:
Orca
Description:
groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy
Steps to Reproduce:
Create a pipeline with the following JSON
{ "appConfig": {}, "expectedArtifacts": [], "keepWaitingPipelines": false, "limitConcurrent": true, "spelEvaluator": "v4", "stages": [ { "clusters": [ { "account": "your-account", "application": "yourapplication", "branch": "develop", "cloudProvider": "appengine", "configArtifacts": [ { "artifact": { "artifactAccount": "github.com", "id": "41dfba03-0c2f-406b-870a-4ab386591504", "name": "app.yaml", "reference": "https://github.com/api/v3/repos/<ORG>/<REPO>/contents/app.yaml", "type": "github/file", "version": "master" } } ], "configFilepaths": [ "app.yaml" ], "configFiles": [], "containerImageUrl": "us.gcr.io/<IMAGE>:<TAG>", "freeFormDetails": "", "fromArtifact": false, "gitCredentialType": "HTTPS_USERNAME_PASSWORD", "interestingHealthProviderNames": [ "App Engine Service" ], "promote": true, "provider": "appengine", "region": "us-east1", "repositoryUrl": "<REPOSITORY_URL>", "sourceType": "containerImage", "stack": "default", "stopPreviousVersion": true, "strategy": "highlander" } ], "name": "Deploy", "refId": "1", "requisiteStageRefIds": [], "type": "deploy" } ] }Attempt to run the pipeline. The following error is shown in Deck.
Why is the artifact being bound to a HashMap?
The text was updated successfully, but these errors were encountered: