test(appengine): Add tests demonstrating AppEngine artifact bug #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply.
This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests.
groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com>
maggieneterval
approved these changes
Jun 24, 2020
ethanfrogers
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
:D whoop, agreed with @maggieneterval - this will be a great example of the new policy!
|
@Mergifyio backport release-1.20.x release-1.19.x |
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2020
* fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com> (cherry picked from commit 4a26d90)
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2020
* fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com> (cherry picked from commit 4a26d90)
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Jun 24, 2020
… (#3774) * fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com> (cherry picked from commit 4a26d90) Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
mergify bot
added a commit
that referenced
this pull request
Jun 24, 2020
…3772) (#3775) * test(appengine): Add tests demonstrating AppEngine artifact bug (#3772) * fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com> (cherry picked from commit 4a26d90) * test(appengine): Fix incorrect class names and imports A refactor between 1.19 and 1.20 changed a lot of class names and import paths, so the backport didn't apply cleanly. This commit updates the (non-compiling) backport so that it refers to the classes as they exist on the 1.19 branch. Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…naker#3772) * fix(provider/appengine): Temporarily revert fix This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply. * test(appengine): Add tests demonstrating AppEngine artifact bug This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests. * fix(provider/appengine): Fix for issue spinnaker/spinnaker#5836 (spinnaker#3755) groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact. Co-Authored-By: Eric Zimanyi <ezimanyi@google.com> Co-authored-by: guido9j <james_guido@homedepot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow the new cherry-pick policy we should have first written a test demonstrating the bug then fixed the test along with the bug fix. This PR does that.
The net effect (when we squash commit) will just be the added tests, but to make it easier to see, the individual commits revert the fix, write some broken tests, then apply the fix and fix the tests.
fix(provider/appengine): Temporarily revert fix
This reverts commit 711c21a. After adding tests to demonstrate the bug and fix, we'll re-apply.
test(appengine): Add tests demonstrating AppEngine artifact bug
This commit adds tests to demonstrate the regression in the AppEngine artifact handling. The next commit will fix the bug and update the tests.
fix(provider/appengine): Fix for issue groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy spinnaker#5836 (fix(provider/appengine): Fix for issue https://github.com/spinnaker/spinnaker/issues/5836 (Master branch) #3755)
groovy.lang.MissingMethodException when referencing github config artifact for GAE deploy. The config artifacts were of instance of HashMap not an Artifact object. Added logic to translate HashMap to Artifact.
Co-Authored-By: Eric Zimanyi ezimanyi@google.com