Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test files #5

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Refactor test files #5

merged 2 commits into from
Feb 17, 2020

Conversation

krwu
Copy link
Contributor

@krwu krwu commented Feb 14, 2020

  • Remove unnecessaryTestApp.php and tests/bootstrap.php, tests will use App\App as well.
  • Fix: tests will delete app/migrations.
  • Add a demo test to tests/Unit

wolfy-j
wolfy-j reviewed Feb 16, 2020
View reviewed changes
app/src/App.php Outdated Show resolved Hide resolved
@wolfy-j
Copy link
Member

wolfy-j commented Feb 16, 2020

I can agree with everything in this PR except exposing the get method.
I'm fine changing my mind though since this is just a project template and you really see the value of doing that.

Thank you for your PR!

@wolfy-j wolfy-j merged commit c320ecc into spiral:master Feb 17, 2020
@wolfy-j
Copy link
Member

wolfy-j commented Feb 17, 2020

Thank you!

@jinrenjie jinrenjie mentioned this pull request Dec 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy-j wolfy-j wolfy-j left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krwu @wolfy-j