Adds null locale processor to remove brackets [[ ... ]] when don't use Translator #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
butschster
commented
Dec 7, 2022
butschster
commented
| Q | A |
|---|---|
| Bugfix? | ❌ |
| Breaks BC? | ❌ |
| New feature? | ✔️ |
…slator component is not installed.
[ci skip] [skip ci]
…nto feature/fake-locale-processor
msmakouz
approved these changes
Dec 7, 2022
Codecov ReportBase: 84.71% // Head: 84.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
============================================
- Coverage 84.71% 84.69% -0.03%
- Complexity 5564 5567 +3
============================================
Files 701 703 +2
Lines 13631 13645 +14
============================================
+ Hits 11547 11556 +9
- Misses 2084 2089 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
roxblnfk
approved these changes
Dec 7, 2022
| */ | ||
| final class NullLocaleProcessor implements ProcessorInterface | ||
| { | ||
| private const REGEXP = '/\[\[(.*?)\]\]/s'; |
There was a problem hiding this comment.
I think locale format should be moved into Stempler. Is it possible?
butschster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.