Parallel MC with OpenMP #625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 27, 2021 12:03
…rithm. A -z configuration would lead to a zero matrix as basis.
…mber of blocks (or exactly one) in each direction. Important for periodic boundary conditions.
GPMueller
requested changes
Feb 13, 2023
| @@ -60,10 +61,74 @@ namespace Engine | |||
|
|
|||
| // TODO: add switch between Metropolis and heat bath | |||
| // One Metropolis step | |||
| Metropolis(spins_old, spins_new); | |||
| Parallel_Metropolis(spins_old, spins_new); | |||
There was a problem hiding this comment.
Is the parallel implementation slower than the sequential version, when running on a single thread?
- If so, it may make sense to be able to switch between them either dynamically (depending on
omp_num_threads) or statically#ifdef SPIRIT_USE_OPENMP - Otherwise, it would make sense to completely replace the
Metropolisimplementation, right? Then there would also be no need to call itParallel_Metropolis.
| // Metropolis iteration with adaptive cone radius | ||
| void Metropolis(const vectorfield & spins_old, vectorfield & spins_new); | ||
| // Parallel MC | ||
| void Parallel_Metropolis(const vectorfield & spins_old, vectorfield & spins_new); |
There was a problem hiding this comment.
As a reference on the implementation (even though you didn't use it as a basis), you could reference David Bauer's diploma thesis, here or in the class comment
muellan
force-pushed
the
develop
branch
9 times, most recently
from
63fbd74
to
2edff73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Monte-Carlo method with OpenMP parallelization.