Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag keys are not prefixed before invalidation #27

Closed
Swanty opened this issue Sep 19, 2016 · 2 comments
Closed

Tag keys are not prefixed before invalidation #27

Swanty opened this issue Sep 19, 2016 · 2 comments
Labels

Comments

@Swanty
Copy link
Contributor

Swanty commented Sep 19, 2016

If you debug here:

$this->deleteItems($tags);

you can see that tags are not prefixed with the lada: prefix

output from redis-cli monitor

1474295382.561930 [2 127.0.0.1:57456] "EXISTS" "lada:tags:database:receptes:table:taxonomy_group"
1474295382.567505 [2 127.0.0.1:57456] "SMEMBERS" "lada:tags:database:receptes:table:taxonomy_group"
1474295382.567958 [2 127.0.0.1:57456] "EXISTS" "lada:tags:database:receptes:table:taxonomy_group:row:6"
1474295382.568279 [2 127.0.0.1:57456] "SMEMBERS" "lada:tags:database:receptes:table:taxonomy_group:row:6"
1474295382.572728 [2 127.0.0.1:57456] "DEL" "lada:ca4f3478a25b1a65e6ba63b3d486464b"
1474295382.573023 [2 127.0.0.1:57456] "DEL" "lada:8878cfb82fadfd146ec585caa3b9df35"
1474295382.573387 [2 127.0.0.1:57456] "DEL" "lada:239982319ac7e7e3bde82a09befe8db7"
1474295382.573605 [2 127.0.0.1:57456] "DEL" "tags:database:receptes:table:taxonomy_group"
1474295382.573867 [2 127.0.0.1:57456] "DEL" "tags:database:receptes:table:taxonomy_group:row:6"
@spiritix
Copy link
Owner

Good find. We should also extend the InvalidatorTest to make sure the tags get deleted properly.

@spiritix spiritix added the bug label Sep 20, 2016
spiritix added a commit that referenced this issue Sep 20, 2016
Properly register singletons + prefix tags before invalidation (issues #27 #29)
@spiritix
Copy link
Owner

Fixed in #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants