Change PkgOpt::validate to use intersects #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple deps were being added to the solution under the same request, so they would overwrite one another. Signed-off-by: J Robert Ray <jrray@jrray.org>
jrray
commented
Sep 3, 2022
| @@ -116,7 +116,7 @@ macro_rules! make_build_and_components { | |||
| let dep = Arc::new($dep.clone()); | |||
| solution.add( | |||
| &$crate::PkgRequest::from_ident( | |||
| recipe.to_ident(), | |||
| $dep.to_ident(), | |||
There was a problem hiding this comment.
I ended up not needing to pass multiple deps to make_build! but this is a bug I ran into.
Add test to demonstrate how `contains` prevents a setup from solving with `spi-platform/2022.4.1.4` when package `openimage` requires `spi-platform/~2022.4.1.3`. Related to #492. Signed-off-by: J Robert Ray <jrray@jrray.org>
jrray
force-pushed
the
jrray/issue492
branch
from
d5f02b8
to
83f9abf
Compare
jrray
changed the title
contains issue
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 67.10% 67.14% +0.03%
==========================================
Files 274 274
Lines 18604 18620 +16
==========================================
+ Hits 12485 12502 +17
+ Misses 6119 6118 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rydrman
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setup is expected to solve, but the use of
containsvsintersectsprevents finding a solution that uses
spi-platform/2022.4.1.4whenpackage
openimageiorequiresspi-platform/~2022.4.1.3.Related to #492.
Signed-off-by: J Robert Ray jrray@jrray.org