Kd/ch96321/create endpoint for getting tax preview information #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdrombosky
requested review from
bobholt,
thisiskseniab,
laynemcnish and
codylee-splice
codylee-splice
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recurly go library that we are using has the incorrect xml structure for subscription data.
This pull request updates the subscription type to get the tax info and invoice number from the place that they are actually located in the recurly response for the version we are using.
It also adds a test file that follows the appropriate xml structure and updates the preview test.
NOTE: I think some other tests are broken because they also use this incorrect xml structure. I can update all of them if I need to, but I only update the preview one as of this PR.