Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many blocks are missing from page response #41

Closed
dvdsgl opened this issue Mar 7, 2021 · 6 comments
Closed

Many blocks are missing from page response #41

dvdsgl opened this issue Mar 7, 2021 · 6 comments

Comments

@dvdsgl
Copy link
Contributor

dvdsgl commented Mar 7, 2021

After a recent update, many blocks are no longer returned for our pages. One page dropped 50-100 blocks from the end of the page.

In page bc7f910ef23b421487ca21b959c67c49, block 771f85de-f188-46e6-90d6-9b2dd814ba10 is listed in the content of the page, but the block content is not actually included.

We noticed that by deleting early blocks on the actual Notion page, missing blocks can be fetched by the API — in other words, blocks at the end of the page are more likely to be missing.

@dvdsgl dvdsgl changed the title Many blocks are missing Many blocks are missing from page response Mar 7, 2021
@transitive-bullshit
Copy link
Contributor

Hmmm, comparing https://www.notion.so/Copy-of-2020-Q4-bc7f910ef23b421487ca21b959c67c49 with https://react-notion-x-demo.transitivebullsh.it/bc7f910ef23b421487ca21b959c67c49, I'm not able to see any difference for the part of the document in question.

Have you tried using https://github.com/NotionX/react-notion-x?

See attached screenshot.

Screen Shot 2021-03-07 at 10 38 59 AM

@transitive-bullshit
Copy link
Contributor

transitive-bullshit commented Mar 7, 2021

This probably has to do with notion-api-worker not fetching as many async blocks as notion-client does https://github.com/NotionX/react-notion-x/blob/master/packages/notion-client/src/notion-api.ts#L71

In particular, I think getPageContentBlockIds is more complex than the version currently in notion-api-worker.

@dvdsgl
Copy link
Contributor Author

dvdsgl commented Mar 7, 2021

Wow! NotionX looks awesome! Trying now 👍

@dvdsgl
Copy link
Contributor Author

dvdsgl commented Mar 7, 2021

I confirmed that notion-client is fetching all of the blocks.

@JhumanJ
Copy link

JhumanJ commented Jul 6, 2021

Hello, any update on this?

@tobiaslins
Copy link
Member

Hey @JhumanJ + @dvdsgl

We just merged this now, thanks @JhumanJ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants