Skip to content

fileicons: allow specify what sizes to dump #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fileicons: allow specify what sizes to dump #1187

wants to merge 1 commit into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jun 9, 2015

this way i could show only 16px icons on webpage:

===== Available File Icons =====

Available ''16x16'' icons:

<html>
<iframe src="/lib/images/fileicons/?size=16" style="border-width:0" width="450" height="190" frameborder="0" scrolling="no"></iframe>
</html>

@glensc
Copy link
Contributor Author

glensc commented Jun 9, 2015

hmm, seems dokuwiki cuts out "src" attribute from iframe, if i add "?" to it's url:

<iframe src="/lib/images/fileicons/?size=16">

results <iframe> without src attribute in browser inspection

screenshot-1

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@Klap-in
Copy link
Collaborator

Klap-in commented Jul 17, 2015

Is this worth inclusion in DokuWiki? I don't see an use case for other users? Is there any use case?
Why don't you duplicate this script in the image folder? that is update save as well.

Where does DokuWiki filter html included in <html> tags? It is not a browser functionality?

@Klap-in
Copy link
Collaborator

Klap-in commented Jul 17, 2015

What happens if you don't show the preview, but show it in an saved page?

@splitbrain
Copy link
Collaborator

Yeah, I don't see much sense in this either. I consider the index.php for the icons more like a gimmik than a feature and I would rather not increase complexity here.

@splitbrain splitbrain closed this Jul 18, 2015
glensc added a commit to pld-linux/dokuwiki that referenced this pull request Jul 19, 2015
@glensc
add option to dump different icon sizes
1813e16 
rejected by upstream
dokuwiki/dokuwiki#1187
@glensc glensc deleted the icon-dump-sizes branch September 27, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: CSS XHTML JS Browsers Feature won't implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glensc @scrutinizer-notifier @Klap-in @splitbrain