Support for PHPUnit 6.0 #1838
Merged
Support for PHPUnit 6.0 #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However those classes are already supported in PHP 5.7 so we can switch to them without breaking backward-compatibility.
See for reference #1837 and sebastianbergmann/phpunit#2503
|
@micgro42, thanks for your PR! By analyzing the history of the files in this pull request, we identified @splitbrain, @Chris--S and @ptbrown to be potential reviewers. |
We still need 5 to test on old php versions, but travis uses 6 for newer PHP versions (and 5 may break on those). Luckily both versions aren't that far apart, yet. This adds a thin adapter class when running on 6.
actually we could right now. but I don't like to introduce that change in a feature branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this (mostly) fixes #1837
If the tests are actually run with PHPUnit 6.0, then the
--globals-backupflag has to be used.