Update html.php #2019
Merged
Update html.php #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$regex initialization added to clearify that it is passed by reference and filled from subroutines
|
I'm merging this, but please use more sensible commit messages next time. When you use the github interface for editing files (which I would not recommend) be sure to edit the prefilled message. |
|
Ok. Would you please give me an example of how YOU would have commented? Just to head in the right direction :-) |
|
"Update html.php" -> "Initialize variable before use" |
splitbrain
added a commit
that referenced
this pull request
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$regex initialization added to clearify that it is passed by reference and filled from subroutines